[vitest-pool-workers] Allow `.wasm` files to be imported as `.wasm?module` by bbridges · Pull Request #11094 · cloudflare/workers-sdk

bbridges · 2025-10-24T18:38:41Z

When loading WASM in module-fallback.ts in vitest-pool-workers, this change trims off a ?module suffix if provided from the module file path. Similar behavior is handled in vite-plugin-cloudflare, where it will trim this suffix.

I ran into an issue using Cloudflare D1 with Prisma since the client generated using

generator client {
  provider = "prisma-client"
  output   = "../src/generated/prisma"
  runtime  = "workerd"
}

included an import import("./query_engine_bg.wasm?module") which could be handled running wrangler dev but couldn't be handled by vitest-pools-workers since it would fail to resolve the module.

A catch with this is if someone is trying to literally import a WASM file with a .wasm?module extension on disk, then it can't be loaded this way.

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: bugfix

changeset-bot · 2025-10-24T18:38:46Z

🦋 Changeset detected

Latest commit: 9fa1d9b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2026-02-10T12:24:58Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11094

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11094

miniflare

npm i https://pkg.pr.new/miniflare@11094

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11094

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11094

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11094

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11094

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11094

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11094

wrangler

npm i https://pkg.pr.new/wrangler@11094

commit: 9fa1d9b

workers-devprod · 2026-03-14T16:40:54Z

Codeowners approval required for this PR:

@cloudflare/wrangler

Show detailed file reviewers

packages/vitest-pool-workers/src/pool/module-fallback.ts: [@cloudflare/wrangler]

workers-devprod · 2026-03-20T20:03:30Z

Codeowners approval required for this PR:

@cloudflare/wrangler

Show detailed file reviewers

packages/vitest-pool-workers/src/pool/module-fallback.ts: [@cloudflare/wrangler]

workers-devprod · 2026-05-01T17:31:38Z

Codeowners approval required for this PR:

@cloudflare/wrangler

Show detailed file reviewers

.changeset/quiet-tools-press.md: [@cloudflare/wrangler]
fixtures/vitest-pool-workers-examples/module-resolution/README.md: [@cloudflare/wrangler]
fixtures/vitest-pool-workers-examples/module-resolution/test/index.spec.ts: [@cloudflare/wrangler]
fixtures/vitest-pool-workers-examples/module-resolution/vendor/wasm-module-dep/add.wasm: [@cloudflare/wrangler]
fixtures/vitest-pool-workers-examples/module-resolution/vendor/wasm-module-dep/index.d.mts: [@cloudflare/wrangler]
fixtures/vitest-pool-workers-examples/module-resolution/vendor/wasm-module-dep/index.mjs: [@cloudflare/wrangler]
fixtures/vitest-pool-workers-examples/module-resolution/vendor/wasm-module-dep/package.json: [@cloudflare/wrangler]
fixtures/vitest-pool-workers-examples/package.json: [@cloudflare/wrangler]
fixtures/vitest-pool-workers-examples/web-assembly/src/index.ts: [@cloudflare/wrangler]
fixtures/vitest-pool-workers-examples/web-assembly/src/wasm-shim.d.ts: [@cloudflare/wrangler]
packages/vitest-pool-workers/src/pool/cloudflare-pool-worker.ts: [@cloudflare/wrangler]
pnpm-lock.yaml: [@cloudflare/wrangler]

Externalize .wasm?module specifiers through the fallback service and normalize Vite @fs paths so dependency-local WASM modules resolve under the Vitest pool.

workers-devprod · 2026-05-07T15:22:53Z

Codeowners approval required for this PR:

✅ @cloudflare/wrangler

Show detailed file reviewers

workers-devprod

Codeowners reviews satisfied

…deps Previously, only literal `await import("./x.wasm?module")` specifiers were rewritten through the static analysis path added in cloudflare#11094. CommonJS dependencies that use `require("./x.wasm?module")` reach the module-fallback service at runtime, where the `?module` suffix went unhandled. The fallback either failed with `No such module "<abs>/x.wasm?module"` or, when a CompiledWasm rule was configured, attempted to evaluate the WebAssembly bytes as JavaScript. These `require()`s work in deployed workers because esbuild's bundler statically rewrites them into ES dynamic imports. vitest-pool-workers' Vite-based pipeline doesn't do that rewrite and instead defers to the module-fallback at runtime. The module-fallback now strips `?module` from the resolved target and synthesizes a CommonJS wrapper that re-`require`s the underlying `.wasm` by absolute path, exposing it on `default` to match what workerd produces for CompiledWasm modules. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

bbridges requested a review from a team as a code owner October 24, 2025 18:38

workers-devprod added this to workers-sdk Feb 10, 2026

github-project-automation Bot moved this to Untriaged in workers-sdk Feb 10, 2026

This comment was marked as resolved.

Sign in to view

petebacondarwin force-pushed the vitest-pool-workers-wasm-module-fix branch from 5b49f2b to d964686 Compare March 14, 2026 16:40

penalosa force-pushed the vitest-pool-workers-wasm-module-fix branch from d964686 to aac0d29 Compare March 20, 2026 20:03

This comment was marked as resolved.

Sign in to view

petebacondarwin requested review from a team and emily-shen and removed request for a team April 15, 2026 06:51

edmundhung requested review from edmundhung and removed request for emily-shen May 1, 2026 14:27

edmundhung requested a review from workers-devprod as a code owner May 1, 2026 17:31

bbridges and others added 3 commits May 5, 2026 11:50

Remove ?module suffix when loading .wasm?module files

2b58955

Add changeset

155cc80

fix: use correct add2Instance variable in wasm?module test

87c9501

edmundhung force-pushed the vitest-pool-workers-wasm-module-fix branch from 92330a5 to ec1ed40 Compare May 5, 2026 11:02

This comment was marked as resolved.

Sign in to view

edmundhung force-pushed the vitest-pool-workers-wasm-module-fix branch 2 times, most recently from f2b25f9 to e512891 Compare May 5, 2026 12:05

fix(vitest-pool-workers): resolve dependency wasm module imports

9fa1d9b

Externalize .wasm?module specifiers through the fallback service and normalize Vite @fs paths so dependency-local WASM modules resolve under the Vitest pool.

edmundhung force-pushed the vitest-pool-workers-wasm-module-fix branch from e512891 to 9fa1d9b Compare May 5, 2026 12:12

penalosa reviewed May 5, 2026

View reviewed changes

Comment thread packages/vitest-pool-workers/src/pool/cloudflare-pool-worker.ts

penalosa approved these changes May 7, 2026

View reviewed changes

workers-devprod approved these changes May 7, 2026

View reviewed changes

github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 7, 2026

penalosa merged commit 9367435 into cloudflare:main May 7, 2026
57 checks passed

github-project-automation Bot moved this from Approved to Done in workers-sdk May 7, 2026

workers-devprod mentioned this pull request May 7, 2026

Version Packages #13851

Merged

tahmid-23 mentioned this pull request Jun 4, 2026

[vitest-pool-workers] Support require("./x.wasm?module") in CommonJS deps #14189

Merged

5 tasks

This was referenced Jun 29, 2026

Version Packages #14433

Merged

Version Packages #14487

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[vitest-pool-workers] Allow `.wasm` files to be imported as `.wasm?module`#11094

[vitest-pool-workers] Allow `.wasm` files to be imported as `.wasm?module`#11094
penalosa merged 4 commits into
cloudflare:mainfrom
bbridges:vitest-pool-workers-wasm-module-fix

bbridges commented Oct 24, 2025 •

edited by edmundhung

Loading

changeset-bot Bot commented Oct 24, 2025 •

edited

Loading

This comment was marked as resolved.

Uh oh!

pkg-pr-new Bot commented Feb 10, 2026 •

edited

Loading

workers-devprod commented Mar 14, 2026

workers-devprod commented Mar 20, 2026

This comment was marked as resolved.

Uh oh!

workers-devprod commented May 1, 2026 •

edited

Loading

This comment was marked as resolved.

Uh oh!

Uh oh!

workers-devprod commented May 7, 2026

workers-devprod left a comment

Uh oh!

Labels

5 participants

Uh oh!

Conversation

bbridges commented Oct 24, 2025 • edited by edmundhung Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

changeset-bot Bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

This comment was marked as resolved.

Uh oh!

pkg-pr-new Bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

workers-devprod commented Mar 14, 2026

workers-devprod commented Mar 20, 2026

This comment was marked as resolved.

Uh oh!

workers-devprod commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

workers-devprod commented May 7, 2026

workers-devprod left a comment

Choose a reason for hiding this comment

Uh oh!

Labels

5 participants

bbridges commented Oct 24, 2025 •

edited by edmundhung

Loading

changeset-bot Bot commented Oct 24, 2025 •

edited

Loading

pkg-pr-new Bot commented Feb 10, 2026 •

edited

Loading

workers-devprod commented May 1, 2026 •

edited

Loading