Repository navigation
Fix workers observability needle schema - #2746
Open
FranciscoMaxwell wants to merge 1 commit into
Open
FranciscoMaxwell wants to merge 1 commit into
FranciscoMaxwell wants to merge 1 commit into
Conversation
jwvdboschHotmail
pushed a commit
to jwvdboschHotmail/cloudflare-python
that referenced
this pull request
Oct 17, 2026
* chore: skip fraud.update test (HTTP 422 from prism) Failure observed in CI run 25171503153 on cloudflare-typescript PR cloudflare#2746.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Fixes #2737.
SharedQueryGetResponse'sRunQueryParametersNeedleValueaBaseModel, matching the same type intelemetry_query_response.py.RunQueryParametersNeedleto rebuild its Pydantic schema.Additional context & links
This avoids the Pydantic schema generation failure reported for the Workers Observability types when newer Pydantic/Python versions eagerly rebuild the model schema.
Tests:
.\.venv\Scripts\python.exe -m pytest tests/api_resources/workers/observability/test_shared_queries.py::TestSharedQueries::test_run_query_parameters_needle_schema_rebuilds.\.venv\Scripts\python.exe -m compileall src/cloudflare/types/workers/observability/shared_query_get_response.py tests/api_resources/workers/observability/test_shared_queries.pyRunQueryParametersNeedle.model_rebuild(force=True)andclient.workersimport/access