Skip to content

ci: move continue-on-error from job level to step level - #2723

Merged
musa-cf merged 1 commit into
nextfrom
apix-852/ci-step-soft-fail
May 18, 2026
Merged

musa-cf merged 1 commit into
nextfrom
apix-852/ci-step-soft-fail

Conversation

@musa-cf

@musa-cf musa-cf commented May 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Move continue-on-error: true from the job level to the step level on test and detect-breaking-changes jobs.

Why: Job-level continue-on-error prevents the workflow from failing but the job itself still reports as failed. If the job is a required status check in branch protection, it still blocks the PR. Step-level continue-on-error makes the job conclude as success while the step output still shows the failure details.

Changes

  • ci.yml: added continue-on-error: true to the "Run tests" step
  • detect-breaking-changes.yml: re-enabled the job (was disabled with if: false), added continue-on-error: true to both the "Detect removed symbols" and "Detect breaking changes" steps

Refs: APIX-852

Job-level continue-on-error only prevents workflow failure but the job
itself still reports as failed, which blocks PRs when the job is a
required status check. Moving it to the step level makes the job
conclude as success while still surfacing failures in the step output.

Also re-enables detect-breaking-changes (was disabled with if: false)
with step-level soft-fail so it runs but does not block.

Refs: APIX-852
@musa-cf musa-cf self-assigned this May 18, 2026
@musa-cf
musa-cf merged commit 5a119e4 into next May 18, 2026
9 checks passed
@musa-cf
musa-cf deleted the apix-852/ci-step-soft-fail branch May 18, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants