Repository navigation
Conversation
commit: |
Contributor
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 175.8 ms | 3.4 ms | 170.1 ms | 181.0 ms |
| base | 182.5 ms | 4.9 ms | 172.7 ms | 197.1 ms |
Δ (PR vs base): ↓ -6.6 ms (-3.6%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
Contributor
|
LGTM |
penalosa
force-pushed
the
penalosa/rust-generator
branch
from
October 13, 2026 21:31
9c91794 to
9cb7ade
Compare
srikrsna
reviewed
Oct 14, 2026
srikrsna
left a comment
srikrsna
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, the only question is how much overhead does cargo run add
Comment on lines
+71
to
+76
| if group.parent().is_some() { | ||
| return Ok(Vec::new().into_iter()); | ||
| } | ||
| let ops = operations(iter::once(group).chain(group.descendants())); | ||
| let command = commands::command(group, &mut Vec::new()); | ||
| Ok(files::command_files(&ops, &command, &self.hand)?.into_iter()) |
Contributor
There was a problem hiding this comment.
Because the handwritten config is already here, if we generate one group at a time, instead of collecting all sub groups, this will run highly concurrently
NuroDev
reviewed
Oct 14, 2026
Member
There was a problem hiding this comment.
Just a helpful FYI: pnpm supports Cargo workspaces too now https://pnpm.io/cargo 🎉
petebacondarwin
requested review from
a team and
petebacondarwin
and removed request for
a team
October 23, 2026 12:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites cf's command generator, previously a TypeScript forge plugin compiled to WebAssembly, as a native Rust crate in
packages/generator.What changed
packages/generator/: newcf-generatorcrate. It uses forge as a library (a git dependency pinned to a commit) and implementsforge::Plugindirectly against forge's model, so there's no WebAssembly component orwit-bindgenlayer. Its only other dependencies areserdeandserde_json, which type the emitted metadata. The emitters write TypeScript withwriteln!and leave whitespace tovp fmt.packages/cli/generator/run.ts: runs the crate withcargo run --release --locked, passing the hand-written registry andmeta.tssidecars as JSON.generate.tsand the test helpers use it.generator/plugin/,generator/index.ts), thetask:generate:plugintask, the vendored@cloudflare/forgetarball,@bytecodealliance/jco, andscripts/sync-forge.ts.cargo test). The forge-model and hand-written-roots tests now run the Rust binary.checkjob runscargo fmt --check,cargo clippy -D warnings, andcargo test --locked.AGENTS.mdfiles are updated for the new layout.Verification
The oracle is the generated output:
pnpm generateleavespackages/cli/src/commands/_generated/byte-for-byte unchanged, so this PR contains no generated diff.pnpm checkpasses.No changeset is included, since the CLI output is unchanged.
Note: generation now needs a Rust toolchain (1.88+). On first run,
cargofetches and compiles forge.