Skip to content

fix: forward cf dev arguments to detected framework servers - #286

Draft
petebacondarwin wants to merge 2 commits into
mainfrom
codex/fix-223-vite-dev-args
Draft

petebacondarwin wants to merge 2 commits into
mainfrom
codex/fix-223-vite-dev-args

Conversation

@petebacondarwin

Copy link
Copy Markdown
Collaborator

cf dev --port 8787 --host 127.0.0.1 currently fails when a framework development command is detected, including projects created by cf init. Forward server arguments through the existing project-command runner, preserve argument boundaries and arguments after --, and update help and generated metadata. Frameworks retain their existing --mode support checks.

Validation:

  • pnpm check passed.
  • 128 related tests passed; 6 Windows-only tests skipped on macOS. Coverage includes Vite, Astro, vinext, the fallback server, and paths containing spaces.
  • Includes a patch changeset.

Fixes #223.

@petebacondarwin
petebacondarwin requested a review from a team as a code owner October 13, 2026 07:23
@pkg-pr-new

pkg-pr-new Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/cf@286

commit: 1249285

@ask-bonk

ask-bonk Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

cf --help startup

mean stddev min max
PR 214.8 ms 6.7 ms 206.0 ms 226.8 ms
base 214.1 ms 6.1 ms 202.2 ms 224.0 ms

Δ (PR vs base): — +0.7 ms (+0.3%)

Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.

@NuroDev
NuroDev enabled auto-merge October 14, 2026 10:35
...getCloudflareRegistryEnvironment(),
},
args: modeArgs,
args: [...modeArgs, ...implArgs],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autoconfig selects package scripts as commands such as npm run dev when a project defines one. Appending the server flags directly produces npm run dev --port 8787, but npm's documented invocation is npm run-script <command> [-- <args>]; consequently the script never receives --port or --host. The new tests only exercise direct npx vite/npx astro commands because their fixtures have no scripts, so this common framework path remains broken. Insert the script-runner separator before forwarded arguments.

Suggested change
args: [...modeArgs, ...implArgs],
args: [
...(details.devCommand.match(/^(?:npm|pnpm|yarn|bun) run\b/)
? ["--"]
: []),
...modeArgs,
...implArgs,
],
@ask-bonk

ask-bonk Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Review: 1 findings.

🤖 I've done a thorough review of your PR.
Forwards cf dev arguments to detected framework servers and updates tests/metadata.

  1. Blocking: Posted one inline suggestion for script-runner argument forwarding.

github run

@petebacondarwin
petebacondarwin marked this pull request as draft October 15, 2026 13:50
auto-merge was automatically disabled October 15, 2026 13:50

Pull request was converted to draft

@petebacondarwin
petebacondarwin requested review from a team and edmundhung and removed request for a team October 23, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants