Repository navigation
Update SDK to fe03060 (4.0.0-9191-92ca830) - #3155
bw-ghapp[bot] wants to merge 22 commits into
Conversation
bw-ghapp
Bot
added
automated-pr
github-actions
Bot
added
app:authenticator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3155 +/- ##
==========================================
+ Coverage 81.82% 81.86% +0.03%
==========================================
Files 1174 1174
Lines 74857 74886 +29
==========================================
+ Hits 61254 61305 +51
+ Misses 13603 13581 -22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Claude finished @bw-ghapp[bot]'s task in 13m 35s —— View job SDK bump evaluated
Evaluated against the Compile-time breaksThe baseline build failed —
The struct went from a lone Call sites, both fixed:
The baseline only reported the first site — compilation stopped before reaching the test helper, which would have failed next. Verifying build passed. Both schemes Two caveats worth recording: the verifying build used the Runtime considerationsNo serialization risk in this range. The two behavioral additions already handled in this PR are both additive and default to absent:
Everything else in range — confirmed safe
Commit
|
sdk-internal#1673 added autotypeGaPolicy to BitwardenSdk.PolicyType, breaking the exhaustive switch in PolicyType(_ sdkType:). iOS has no autotype equivalent, so it joins the existing SDK-only group mapping to .unknown.
|
Warning @bw-ghapp[bot] Uploading code coverage report failed. Please check the "Upload to codecov.io" step of Process Test Reports job for more details. |
The SDK bump adds LoginView.httpAuthenticationEnabled, a new optional field with a `= nil` default in the memberwise initializer. Both iOS code paths that rebuild a LoginView from an existing one copy every other field forward, so they compiled unchanged but silently reset the new field to nil — editing a cipher on iOS would wipe a value set by another client. - LoginView.init(loginView:loginState:) — the add/edit save path - LoginView.update(totp:) — the TOTP-key copy used by item selection Sites that build a brand new cipher (LoginItemState.loginView, CipherView+Extensions, BitwardenSdk+Vault) are left alone; nil is correct there. Also adds the parameter to the LoginView test fixture and updates the AddItemStateTests inline snapshots, which now include the new field.
The hand-written mock encrypt/decrypt round-trip in BitwardenSdk+VaultMocking dropped the new Login/LoginView.httpAuthenticationEnabled field, so any test routing a login cipher through MockVaultClientService silently lost the flag. The generated memberwise init defaults the parameter to nil, so this compiled clean while breaking at runtime. Also adds the parameter to the BitwardenSdk.Login.fixture helper to match the LoginView.fixture helper already updated on this branch.
sdk-internal#1587 added folderName, collectionNames, organizationName, creationDate and revisionDate to SendItemMetadata. UniFFI generates the memberwise init without default values, so both construction sites fail to compile. SendDataModel carries no counterpart data for any of the new fields, so the API mapping passes nil, matching the existing PM-41094 TODO. The test fixture exposes them as defaulted parameters, following the convention of the surrounding fixtures.
Updates the SDK from
677a979e8f137f67979cabed9a88e9805009e80etofe03060a7a643ba4385b503296fc28354dfbe728Warning
Breaking changes detected
What's Changed
Raw changelog