Skip to content

bug: shell fallback for try-summary and and try-commit break on filenames with newlines #84

Open

Description

@angelhof

By @mgree:

The logic could break with particularly nasty filenames (e.g., newlines). The most robust approach is to null terminate, à la find ... -print0 or xargs -0.

(See the discussion in #83)

Activity

  1. mgree commented on Jun 11, 2024

    @mgree
    Contributor

    I was going to take a whack at fixing this in the shell fallbacks in #158, but it's a bigger overhaul than I initially expected: we can't store the results of find -print0 in a variable. 🥲

  2. changed the title [-]Summary and Commit break with "bad" filenames[/-] on Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions