Skip to content

fix(mbpseudo): resolve artist aliases per track - #7140

Open
OKAN-SOFTWARE wants to merge 3 commits into
beetbox:masterfrom
OKAN-SOFTWARE:fix/mbpseudo-per-track-aliases-7125
Open

OKAN-SOFTWARE wants to merge 3 commits into
beetbox:masterfrom
OKAN-SOFTWARE:fix/mbpseudo-per-track-aliases-7125

Conversation

@OKAN-SOFTWARE

Copy link
Copy Markdown

Summary

Fixes #7125.

The mbpseudo plugin previously selected the first matching artist alias from the release group and applied it to every track. This produced incorrect translated artist tags on albums containing multiple artists.

Changes

  • Resolve artist aliases independently for each track.
  • Preserve MusicBrainz artist-credit join phrases.
  • Handle recording-level artist credits when track-level credits are missing.
  • Fall back to the original artist name when no matching alias exists.
  • Reuse the existing MusicBrainz artist-credit parser with an explicit language preference.
  • Add regression coverage for albums with multiple artists.

Validation

  • Full plugin suite: 1,285 passed, 64 skipped
  • Focused MusicBrainz tests: 76 passed
  • Mypy type checking: passed
  • Ruff lint and formatting: passed
  • Git whitespace validation: passed

The regression test reproduced the original issue before the fix and passed afterward.

@OKAN-SOFTWARE
OKAN-SOFTWARE requested review from a team, asardaes and snejus as code owners November 1, 2026 01:26
@github-actions github-actions Bot added the mbpseudo mbpseudo plugin label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mbpseudo mbpseudo plugin

1 participant