Skip to content

chore: update generated KMS code - #580

Merged
alex-chew merged 6 commits into
mainlinefrom
update-kms-generated-code
May 18, 2022
Merged

chore: update generated KMS code#580
alex-chew merged 6 commits into
mainlinefrom
update-kms-generated-code

Conversation

@alex-chew

@alex-chew alex-chew commented May 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description of changes: Updates generated KMS SDK code/shims, and manually-written externs that interact with them. This PR does not include or require any changes to "customer code"; public APIs are untouched.

This corresponds to codegen PR smithy-lang/smithy-dafny#23.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@alex-chew
alex-chew requested a review from a team as a code owner May 13, 2022 00:46
@alex-chew alex-chew mentioned this pull request May 13, 2022
Merged
@texastony

texastony commented May 13, 2022

Copy link
Copy Markdown
Contributor

Dafny Verification failed:

Verifying AwsCryptographicMaterialProviders/TestDefaultClientProvider.dfy failed:
  /Users/runner/work/aws-encryption-sdk-dafny/aws-encryption-sdk-dafny/test/AwsCryptographicMaterialProviders/TestDefaultClientProvider.dfy(56,18): Error: unresolved identifier: CastKeyManagementServiceErrorToString
  1 resolution/type errors detected in TestDefaultClientProvider.dfy
  Results File: /Users/runner/work/aws-encryption-sdk-dafny/aws-encryption-sdk-dafny/test/TestResults/_Mac-1652402358456_2022-05-13_00_41_42.trx

The test builds in CodeBuild also failed.
I think you need to update TestDefaultClientProvider.
@alex-chew

alex-chew commented May 13, 2022

Copy link
Copy Markdown
Contributor Author

Oops, good catch. Fixed in latest commit.
@alex-chew
alex-chew marked this pull request as draft May 13, 2022 16:55
@alex-chew
alex-chew marked this pull request as ready for review May 17, 2022 23:12
@alex-chew
alex-chew merged commit c8be143 into mainline May 18, 2022
@alex-chew
alex-chew deleted the update-kms-generated-code branch May 18, 2022 21:57
@dependabot dependabot Bot mentioned this pull request Nov 2, 2025
Closed
This was referenced Nov 10, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Nov 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@alex-chew @texastony @farleyb-amazon