Repository navigation
fix(idempotency): retain cache locks without execution deadlines - #5680
Merged
Merged
Conversation
dreamorosi
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redis/Valkey idempotency records without an execution deadline are currently treated as orphaned, allowing overlapping calls to execute the same operation. Keep these records locked until their overall expiry when no Lambda context has been registered.
Changes
INPROGRESSrecords with no execution deadline.Validation: 139 idempotency unit tests passed with 100% coverage, and TypeScript and changed-file lint checks passed. All four live Redis 7.4.11 cases passed after the fix, including overlapping wrapper calls with and without a Lambda context.
Issue number: closes #5678
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.