Repository navigation
refactor(testing): remove withResolvers polyfill, use native method - #5427
Merged
Merged
Conversation
The withResolvers helper was a polyfill for Promise.withResolvers, needed only while the project supported Node.js 20. Now that the minimum supported runtime is Node.js 22, where the static method is natively available, replace the internal usage in sequence() with Promise.withResolvers and drop the polyfill and its export. Fixes #5411
svozza
approved these changes
Jul 8, 2026
powertools-for-aws-oss-automation
Bot
added
size/M
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
withResolvers()polyfill from@aws-lambda-powertools/testing-utilsin favor of the nativePromise.withResolversstatic method. The polyfill's own doc comment marked it as temporary, to be removed once Node.js 20 support was dropped — which has now happened (supported runtimes are Node.js 22 and 24, where the native method is available). Since testing-utils is a private, internal-only package, there is no customer-facing change.Changes
sequence()utility with nativePromise.withResolvers<void>()(packages/testing/src/helpers.ts)withResolversfunction and its doc comment frompackages/testing/src/helpers.tswithResolversexport frompackages/testing/src/index.tssequence()consumer (logger concurrency unit tests) passesIssue number: closes #5411
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.