Repository navigation
chore: approve install scripts for npm v12 allowScripts - #5340
Merged
Merged
Conversation
npm v12 (~July 2026) flips allowScripts to opt-in; without an allowlist, dependency install scripts are silently skipped. - esbuild, fsevents: name-only (unpinned) so dependabot bumps don't strand a stale pin - protobufjs@7.5.8: pinned; only the nested copy under @valkey/valkey-glide has a postinstall (removed in v8), so the entry dies with valkey-glide's next protobufjs major Closes #5321
powertools-for-aws-oss-automation
Bot
added
size/XS
dreamorosi
approved these changes
Jun 12, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm v12 (estimated July 2026) flips
allowScriptsfrom opt-out to opt-in: dependency install scripts (preinstall/install/postinstall) will be silently skipped unless explicitly allowlisted inpackage.json. This PR commits the allowlist to the rootpackage.jsonnow, covering the only three dependencies in our tree that run install scripts, so installs keep working unchanged when npm v12 ships.Consumers of our published packages are unaffected — none of the workspace packages declare install scripts.
Changes
allowScriptsblock to rootpackage.json(generated vianpm approve-scriptson npm 11.16.0):esbuildandfseventsapproved name-only (unpinned, via--no-allow-scripts-pin) so dependabot version bumps don't strand a stale pin that would silently re-block the script under v12protobufjs@7.5.8approved pinned; only the nested copy under@valkey/valkey-glidehas a postinstall (removed in protobufjs v8), so the entry can be deleted when valkey-glide moves to protobufjs 8npm approve-scripts --allow-scripts-pendingreports no unreviewed install scripts, andnpm installcompletes with no allowScripts warnings and no lockfile changesIssue number: closes #5321
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.