Repository navigation
fix(logger): flush log buffer on critical() when flushOnErrorLog is e… - #5227
Merged
svozza merged 2 commits intoMay 7, 2026
Merged
Conversation
…nabled Centralizes the flush-on-error logic from error() into processLogItem() so that any log level >= ERROR (including CRITICAL) will automatically flush the buffer when flushOnErrorLog is enabled. Previously, only error() checked flushOnErrorLog and flushed the buffer. critical(), despite being more severe, did not flush — causing buffered diagnostic logs to be silently discarded. Closes aws-powertools#5210
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
svozza
reviewed
May 7, 2026
Contributor
|
One minor comment but other than that LGTM! |
svozza
self-requested a review
May 7, 2026 11:33
svozza
requested changes
May 7, 2026
powertools-for-aws-oss-automation
Bot
added
size/M
|
svozza
approved these changes
May 7, 2026
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Centralizes the flush-on-error logic from
error()intoprocessLogItem()so that any log level>= ERROR(includingCRITICAL) will automatically flush the buffer whenflushOnErrorLogis enabled.Previously, only
error()checkedflushOnErrorLogand flushed the buffer.critical(), despite being more severe, did not flush — causing buffered diagnostic logs to be silently discarded.What changed
Logger.ts: Removed the buffer flush check fromerror()and moved it intoprocessLogItem(), which all log level methods funnel through. The condition checkslogLevel >= LogLevelThreshold.ERROR && logLevel < LogLevelThreshold.SILENTto cover bothERRORandCRITICALwhile excludingSILENT.logBuffer.test.ts: Added two unit tests:critical()flushes the buffer whenflushOnErrorLogis enabled (default)critical()does not flush the buffer whenflushOnErrorLogis explicitly disabledIssue number: Closes #5210
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.