Repository navigation
fix(logger): correctly serialize shared object references in JSON replacer - #5186
Merged
Merged
Conversation
…lacer Replace WeakSet with ancestor-chain tracking in getJsonReplacer() to distinguish duplicate references from true circular references. The WeakSet remembered every object visited during serialization, causing shared objects (e.g. spread array elements) to serialize as null.
Capture only the needed values (jsonReplacerFn, logFormatter) in the closure instead of the entire Logger instance. Resolves SonarQube S7740 (do not assign this to self).
Resolves SonarQube S7755 (prefer .at() over complex index access).
powertools-for-aws-oss-automation
Bot
added
size/M
dreamorosi
reviewed
Apr 15, 2026
dreamorosi
approved these changes
Apr 16, 2026
powertools-for-aws-oss-automation
Bot
added
size/M
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Logger's
getJsonReplacer()used aWeakSetto detect circular references during JSON serialization, which incorrectly treated duplicate object references as circular. This caused shared objects (e.g. spread array elements) to serialize asnullin arrays or be omitted from objects.Changes
WeakSetwith ancestor-chain tracking ingetJsonReplacer()— only objects on the current path from root to the node being serialized are tracked, allowing the same object to appear in multiple branches while still detecting true circular referencesJSON.stringifycan bindthisto the parent object, enabling ancestor-chain pruningIssue number: closes #5167
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.