Repository navigation
fix(kafka): handle tombstone events - #4991
Merged
Merged
Conversation
svozza
reviewed
Feb 5, 2026
- Add null/undefined checks in value getter similar to key getter - Prevents TypeError when accessing null.length in fromBase64 - Tombstone events now properly return null instead of throwing - Fixes issue #4988
- Add test case for undefined value to achieve 100% coverage - Ensures undefined values return undefined as expected
- Replace 'as any' with 'as unknown as string' for better type safety - Maintains test functionality while avoiding any type usage
dreamorosi
force-pushed
the
fix/kafka-tombstone-events
branch
from
February 6, 2026 10:55
fb63162 to
a773f0a
Compare
|
svozza
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Kafka consumer was failing when processing tombstone events (messages with null values) because the
valuegetter attempted to deserialize null values, causing a TypeError whenfromBase64tried to access thelengthproperty of null.Changes
Fixed the issue by adding null and undefined checks to the
valuegetter in the consumer, mirroring the existing logic in thekeygetter. When a tombstone event is encountered, the consumer now properly returnsnullinstead of throwing an error.Updated type definitions to allow
nullvalues in the deserialization chain and added comprehensive test coverage for both null and undefined value scenarios.Issue number: closes #4988
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.