Skip to content

feat: add pre-commit hooks - #64

Merged
heitorlessa merged 9 commits into
aws-powertools:developfrom
heitorlessa:feat/precommit-hooks
Jun 7, 2020
Merged

heitorlessa merged 9 commits into
aws-powertools:developfrom
heitorlessa:feat/precommit-hooks

Conversation

@heitorlessa

@heitorlessa heitorlessa commented Jun 7, 2020 •

Copy link
Copy Markdown
Contributor

Issue #, if available: #33

Description of changes:

Added the following checks to run locally before committing/pushing.

  • check-merge-conflict
  • trailing-whitespace
  • end-of-file-fixer
  • check-toml
  • python-use-type-annotations
  • black
  • isort
  • flake8

Breaking change checklist

Ignore if it's not a breaking change

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
@heitorlessa
heitorlessa requested a review from to-mc June 7, 2020 13:39
@heitorlessa
heitorlessa requested a review from nmoutschen June 7, 2020 13:42
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
@codecov-commenter

codecov-commenter commented Jun 7, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #64 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          496       496           
  Branches        45        45           
=========================================
  Hits           496       496           
Impacted Files Coverage Δ
...ws_lambda_powertools/middleware_factory/factory.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993e8e5...15d97f1. Read the comment docs.

@heitorlessa heitorlessa mentioned this pull request Jun 7, 2020
29 of 30 tasks
* develop:
  improv: include example tests in `make tests` (#63)
  chore: rename Makefile target docs-dev to docs-local (#65)
  improv: better namespace/dimension handling for Metrics (#62)
Comment thread Makefile Resolved
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
@heitorlessa
heitorlessa force-pushed the feat/precommit-hooks branch from ae3cacb to 15d97f1 Compare June 7, 2020 15:50
@heitorlessa
heitorlessa merged commit c98937b into aws-powertools:develop Jun 7, 2020
@heitorlessa
heitorlessa deleted the feat/precommit-hooks branch June 7, 2020 17:51
heitorlessa added a commit that referenced this pull request Jun 10, 2020
* develop: (31 commits)
  docs: fix contrast on highlighted code text (#73)
  feat: improve error handling for log_metrics decorator (#71)
  chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs
  feat: add high level imports (#70)
  fix: correct env var name for publish to pypi test (#69)
  chore: version bump (#68)
  feat: add capture_cold_start_metric for log_metrics (#67)
  chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66)
  feat: automate publishing to pypi (#58)
  feat: add pre-commit hooks (#64)
  improv: include example tests in `make tests` (#63)
  chore: rename Makefile target docs-dev to docs-local (#65)
  improv: better namespace/dimension handling for Metrics (#62)
  docs: build on master only
  chore: correct docstring for log_metrics
  chore: fix typo in metrics doc
  chore: Correct test comment
  chore: remove unused import
  chore: formatting
  feat: update Metrics interface to resemble tracer & logger: use "service" as its namespace.
  ...
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
* chore: pre-commit dep

Signed-off-by: heitorlessa <lessa@amazon.co.uk>

* feat: add initial pre-commit config

Signed-off-by: heitorlessa <lessa@amazon.co.uk>

* feat: additional type annotation, toml, merge, etc

Signed-off-by: heitorlessa <lessa@amazon.co.uk>

* improv: speed up formatting

Signed-off-by: heitorlessa <lessa@amazon.co.uk>

* fix: python version range

Signed-off-by: heitorlessa <lessa@amazon.co.uk>

* chore: pre-commit checks

* chore: update dev deps

* feat: install pre-commit hooks during dev

Signed-off-by: heitorlessa <lessa@amazon.co.uk>
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
…tools-python into develop

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: (104 commits)
  feat: add metrics metadata (#81)
  chore: cleanup tests (#79)
  chore: remove deprecated code before GA (#78)
  docs: customize contributing guide (#77)
  chore: move blockquotes as hidden comments
  chore: update CHANGELOG
  chore: bump version to 0.11.0 (#76)
  chore: version bump 0.10.1
  fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74)
  fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74)
  docs: fix contrast on highlighted code text (#73)
  feat: improve error handling for log_metrics decorator (#71)
  chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs
  feat: add high level imports (#70)
  fix: correct env var name for publish to pypi test (#69)
  chore: version bump (#68)
  feat: add capture_cold_start_metric for log_metrics (#67)
  chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66)
  feat: automate publishing to pypi (#58)
  feat: add pre-commit hooks (#64)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants