refector: Add LiveManifestEntry - #3132
Open
xanderbailey wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This came up as a part of the discussion in perf(deletes): Implement filtering position delete files by file path #2936
What changes are included in this PR?
This PR adds
LiveManifestEntry, an internal representation used during scan planning.ManifestEntrycontinues to reflect the serialized manifest format, wheresequence_numberis optional because anADDEDentry may inherit it from the containing manifest. After inheritance, however, every live entry must have a data sequence number, soLiveManifestEntryrepresents that the value is required.The distinction also preserves compatibility with older v2 manifests that contain deleted entries with null data sequence numbers. Those entries can still be parsed and ignored because they are no longer live, while an
ADDEDorEXISTINGentry that remains null after inheritance is treated as invalid data.This invariant is intentionally not enforced in ManifestReader::read. The manifest reader loads the complete manifest, including deleted historical entries, and is used outside scan planning. Rejecting null sequence numbers there would make an otherwise readable manifest fail because of an entry that cannot affect the current snapshot. Instead, the scan path applies inheritance first, filters out deleted entries, and then converts the remaining entries into LiveManifestEntry.
Scan and delete-index code now operate on
LiveManifestEntry, removing optional sequence-number comparisons and the previous fallback that applied deletes unconditionally when the data sequence number was missing.Are these changes tested?
AI Disclosure