Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the callback timing changes from nanoseconds to microseconds.
No open issues 🎉
What changed in this PR
This PR corrects event dispatcher callback timing to use microseconds, matching LatencyRecorder’s default unit.
Changes:
- Switches read and write callback measurements from nanoseconds to microseconds in both dispatcher backends.
- Renames timing variables to
start_us, keeping names consistent with the recorded values.
| File | Description |
|---|---|
src/brpc/event_dispatcher_kqueue.cpp |
Records kqueue read/write callback durations in microseconds. |
src/brpc/event_dispatcher_epoll.cpp |
Records epoll read/write callback durations in microseconds. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
What is changed and the side effects?
LatencyRecorder defines
latency_us = latency * latency_scale_factor, with latency_scale_factor defaulting to 1. Therefore, callback durations passed to the recorder should be in microseconds under the default configuration.A callback lasting over approximately 2.15 seconds could produce an IntRecorder overflow warning.
Changed:
Event dispatcher read and write callback durations should measured in microsecond values.
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: