Increase font-size and fix other a11y issues#181
Open
2ndkauboy wants to merge 1 commit intoWordPress:trunkfrom
Open
Increase font-size and fix other a11y issues#1812ndkauboy wants to merge 1 commit intoWordPress:trunkfrom
2ndkauboy wants to merge 1 commit intoWordPress:trunkfrom
Conversation
ironnysh
reviewed
Dec 25, 2023
|
|
||
| #commentform p { | ||
| font-size: 10px; | ||
| font-size: 16px; |
There was a problem hiding this comment.
Hi, since this PR hasn’t been merged yet, I wanted to suggest avoiding setting font sizes in pixels, instead opting for rem units (i.e., font-size: 1rem;).
Author
There was a problem hiding this comment.
I would usually agree. But since the whole CSS for the theme is always using px values for font-size, I would not use relative units for this change.
There is an initiative to create a completely new WordPress.tv theme and in this one relative units will be used.
ironnysh
reviewed
Dec 25, 2023
|
|
||
| .commenttext p { | ||
| margin-bottom: 1em; | ||
| font-size: 16px; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: #1456