DO NOT MERGE: wp_list_pluck() object regression tests - before and after r57698#6180
Draft
hellofromtonya wants to merge 1 commit intoWordPress:trunkfrom
Draft
DO NOT MERGE: wp_list_pluck() object regression tests - before and after r57698#6180hellofromtonya wants to merge 1 commit intoWordPress:trunkfrom
wp_list_pluck() object regression tests - before and after r57698#6180hellofromtonya wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1. Restores the original code to run using a temporary $GLOBAL['before_r57698']. 2. Adds regression tests for before and after r57698 for the following scenarios: * Class with __get() and __isset(). * Class with __get() but not __isset(). * Dynamic property on each of the class types above. * A field within an allow list property accessible only through magic method(s).
hellofromtonya
force-pushed
the
test/before_after_r57698
branch
from
ea95d99 to
a174e29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT REVIEW OR COMMIT THIS PR.
Purpose: to better understand and demonstrate how
wp_list_pluck()used to and now should handle different object scenarios, such as:__get()and__isset().__get()but no__isset().__isset()that does not handlenull.The original code before r57698 is run via a global
$GLOBALS['before_r57698'].Trac ticket: https://core.trac.wordpress.org/ticket/59774
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.