Skip to content

Build/Test Tools: Add -v1 suffix to TypeScript/PHPStan reusable workflows and remove unused Dependabot exclusion#11163

Closed
westonruter wants to merge 2 commits intoWordPress:trunkfrom
westonruter:update/type-checking-workflows
Closed

Build/Test Tools: Add -v1 suffix to TypeScript/PHPStan reusable workflows and remove unused Dependabot exclusion#11163
westonruter wants to merge 2 commits intoWordPress:trunkfrom
westonruter:update/type-checking-workflows

Conversation

@westonruter
Copy link
Member

Trac ticket: https://core.trac.wordpress.org/ticket/64662

  • Add -v1 suffix to reusable workflows for JavaScript type checking and PHPStan analysis: This follows the established convention of including a version suffix for reusable workflow files, ensuring consistency with other workflows like PHPUnit.
  • Remove Dependabot exclusion from type checking workflows: Since Dependabot was deactivated in b60c06c and other bot-specific checks were removed in 26230c3, this exclusion is no longer necessary.

Use of AI Tools

Feedback from @desrosj fed into Gemini CLI to implement.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

westonruter and others added 2 commits March 4, 2026 15:33
… type checking and PHPStan analysis.

This follows the established convention of including a version suffix for reusable workflow files, ensuring consistency with other workflows like PHPUnit.

Follow up to r61830, r61699.

Co-authored-by: gemini-cli <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Desrosiers <desrosj@git.wordpress.org>
…flows.

Since Dependabot was deactivated in b60c06c and other bot-specific checks were removed in 26230c3, this exclusion is no longer necessary.

Follow up to r61830, r61699.

Co-authored-by: gemini-cli <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Desrosiers <desrosj@git.wordpress.org>
@westonruter westonruter requested a review from desrosj March 4, 2026 23:37
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @westonruter!

@westonruter westonruter changed the title Build/Test Tools: Add -v1 suffix to TypeScript/PHPStan reusable workflows and remove dependabot Mar 5, 2026
pento pushed a commit that referenced this pull request Mar 5, 2026
…kflows and remove unused Dependabot exclusion.

Developed in #11163

Follow up to r61830, r61699, r61050, r61049.

Props desrosj, westonruter.
See #61175.
Fixes #64662.


git-svn-id: https://develop.svn.wordpress.org/trunk@61837 602fd350-edb4-49c9-b593-d223f7449a82
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61837
GitHub commit: a479b0a

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 5, 2026
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Mar 5, 2026
…kflows and remove unused Dependabot exclusion.

Developed in WordPress/wordpress-develop#11163

Follow up to r61830, r61699, r61050, r61049.

Props desrosj, westonruter.
See #61175.
Fixes #64662.

Built from https://develop.svn.wordpress.org/trunk@61837


git-svn-id: http://core.svn.wordpress.org/trunk@61124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants