Build: Fix Gutenberg copy script missing constants.php and incorrect base URL#10965
Build: Fix Gutenberg copy script missing constants.php and incorrect base URL#10965youknowriad wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…base URL. The copy script was not including `constants.php` in the list of PHP infrastructure files to sync from Gutenberg's build output to Core. Additionally, the base URL passed to the Gutenberg build had the trailing slash outside the `includes_url()` call, resulting in URLs like `build/pages` being generated as `buildpages`. Props youknowriad. Fixes #64656. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e0f8d7e to
3241835
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
ellatrix
left a comment
There was a problem hiding this comment.
Thanks, Font Library works now.
Summary
The previous Gutenberg hash upgrade brought a new
@wordpress/buildpackage to Core but the build scripts in Core were not updated in consequence. It resulted in a broken font library page. This PR fixes it.constants.phpto the list of PHP infrastructure files copied from Gutenberg's build output to Core incopy-gutenberg-build.js--base-urlargument inbuild-gutenberg.jsto include the trailing slash insideincludes_url('build/')instead of outside the function callfasttoskip-typesto get back to sane performance for CI jobs and gutenberg builds.Fixes https://core.trac.wordpress.org/ticket/64656.
Test plan
🤖 Generated with Claude Code