Conversation
Removed "Health Check" from the Persistent Object Cache title, since we don't use that title elsewhere
mxbclang
added
Infrastructure
tillkruss
approved these changes
Aug 3, 2022
mukeshpanchal27
approved these changes
Aug 4, 2022
merkys7
approved these changes
Aug 4, 2022
felixarntz
reviewed
Aug 8, 2022
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@bethanylang One point of feedback here.
| /tests/testdata/modules/site-health/audit-enqueued-assets @manuelRod | ||
|
|
||
| # Module: Persistent Object Cache Health Check | ||
| # Module: Persistent Object Cache |
Member
There was a problem hiding this comment.
The names here are all based on the actual module name. If we change this here, we should probably rename the module itself as well (in modules/object-cache/persistent-object-cache-health-check/load.php).
Member
|
@bethanylang Actually, the change here is somewhat doing the opposite renaming from what #423 is doing. So we should align on going with one of these 2 naming approaches. cc @OllieJones |
3 tasks
Member
|
@bethanylang Given that in #423 we have decided to use the "Health Check" suffix as the convention, I believe this PR is now obsolete. Is that correct? |
Contributor
Author
|
@felixarntz Yep, that's right! Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed "Health Check" from the Persistent Object Cache title, since we don't use that title elsewhere
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.