Skip to content

Add guidance for managing Performance feature plugins#1734

Merged
felixarntz merged 8 commits intoWordPress:trunkfrom
ShyamGadde:add/performance-features-management-guidance
Dec 16, 2024
Merged

Add guidance for managing Performance feature plugins#1734
felixarntz merged 8 commits intoWordPress:trunkfrom
ShyamGadde:add/performance-features-management-guidance

Conversation

@ShyamGadde
Copy link
Contributor

@ShyamGadde ShyamGadde commented Dec 11, 2024 •
edited
Loading

Summary

Fixes #1695

Relevant technical choices

Added an informative paragraph to the bottom of the Performance Features screen as seen in the screenshot below:
image
@ShyamGadde
Add guidance for managing Performance feature plugins
5c77386 
Signed-off-by: Shyamsundar Gadde <shyamsundar.gadde@rtcamp.com>
@ShyamGadde

This comment was marked as resolved.

Sign in to view
@ShyamGadde ShyamGadde marked this pull request as ready for review December 11, 2024 18:00
@github-actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ShyamGadde <shyamgadde@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: paaljoachim <paaljoachim@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
felixarntz
felixarntz reviewed Dec 11, 2024
View reviewed changes
plugins/performance-lab/includes/admin/plugins.php Outdated
printf(
/* translators: %1$s: opening anchor tag, %2$s: closing anchor tag */
esc_html__( 'Performance features are installed as plugins. To update features or remove them, %1$s manage them on the plugins screen. %2$s', 'performance-lab' ),
'<a href="' . esc_url( admin_url( 'plugins.php?s=WordPress%20Performance%20Team&plugin_status=all' ) ) . '">',
Copy link
Member

@felixarntz felixarntz Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use add_query_arg() here instead?
Copy link
Contributor Author

@ShyamGadde ShyamGadde Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 8f670f5.
@ShyamGadde
Replace hardcoded URL with add_query_arg()
8f670f5 
Signed-off-by: Shyamsundar Gadde <shyamsundar.gadde@rtcamp.com>
@westonruter westonruter added this to the performance-lab n.e.x.t milestone Dec 11, 2024
@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Dec 11, 2024
westonruter
westonruter reviewed Dec 12, 2024
View reviewed changes
mukeshpanchal27
mukeshpanchal27 reviewed Dec 12, 2024
View reviewed changes
@westonruter
Copy link
Member

westonruter commented Dec 12, 2024

What do you think about centering the text?

Screen.recording.2024-12-12.09.39.01.webm
@felixarntz
Copy link
Member

felixarntz commented Dec 12, 2024

+1 for the notice-info at the bottom. I think on the top is too prominent and distracting from the main purpose of the page, but the notice formatting makes most sense to me.
@westonruter
Copy link
Member

westonruter commented Dec 14, 2024

IMO, aligning the text center looks better:

Screen.recording.2024-12-13.16.27.48.webm

Compared with notice info:

Screen.recording.2024-12-13.16.26.49.webm

@adamsilverstein What do you think?
westonruter
westonruter reviewed Dec 14, 2024
View reviewed changes
westonruter
westonruter reviewed Dec 14, 2024
View reviewed changes
@westonruter
Copy link
Member

westonruter commented Dec 14, 2024

I added the two options as suggestions. I can go with either, although I slightly prefer Option 1. Someone please accept the suggestion they think is better, and then we can merge this PR.
@westonruter

This comment was marked as resolved.

Sign in to view
felixarntz
felixarntz requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter @ShyamGadde Noticing one more small but important thing here that needs to be fixed before merge.
ShyamGadde and others added 3 commits December 16, 2024 13:34
felixarntz
felixarntz approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShyamGadde, looks great!
@felixarntz felixarntz merged commit 1d44f3a into WordPress:trunk Dec 16, 2024
@westonruter westonruter mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature

4 participants

@ShyamGadde @westonruter @felixarntz @mukeshpanchal27