Improve Performance screen when external requests to WordPress.org fail#1474
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @chimok. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
felixarntz
left a comment
There was a problem hiding this comment.
@westonruter +1 to this nice little UX improvement for when things are broken :)
This reminds me that it would be great to avoid all these individual requests. The more plugins we add, the more of a bottleneck / failure risk they'll become.
I don't think wordpress.org has an API endpoint to get the same data for multiple plugins in bulk, but exploring Requests::request_multiple() might be a good idea. On the other hand, this would require some hacks because the way WordPress core wraps the regular Request::request() method makes for different behavior. I wish WordPress core just had wp_request_multiple()... 😮💨
|
@westonruter The wp_admin_notice return empty |
Co-authored-by: Weston Ruter <westonruter@google.com>
Fixes #1473.
With the following plugin code active:
Before:
After: