Prioritize loading poster image of video LCP elements#1377
Prioritize loading poster image of video LCP elements#1377thelovekesh wants to merge 3 commits intotrunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
thelovekesh
added
[Type] Feature
| $crossorigin = $processor->get_attribute( 'crossorigin' ); | ||
| if ( is_string( $crossorigin ) ) { | ||
| $link_attributes['crossorigin'] = 'use-credentials' === $crossorigin ? 'use-credentials' : 'anonymous'; | ||
| } |
There was a problem hiding this comment.
@westonruter The Poster image uses the crossorigin from the video tag, right?
| ); | ||
|
|
||
| $crossorigin = $processor->get_attribute( 'crossorigin' ); | ||
| if ( is_string( $crossorigin ) ) { |
There was a problem hiding this comment.
In the case of <video src="..." crossorigin> then it would actually be true. So I think what you want there is:
| if ( is_string( $crossorigin ) ) { | |
| if ( null !== $crossorigin ) { |
westonruter
modified the milestones:
image-prioritizer 0.2.0,
image-prioritizer n.e.x.t
|
Closing in favor of #1498. cc @westonruter |
2 participants
Summary
Fixes #1183
Relevant technical choices