Conversation
|
Hey @ashiramin 👋 Could you fill out the PR template here? It would be helpful to know what you're working on so we can better guide you. I'm guessing you're targeting #4884. It's failing the linter, you can see the error running the command: Add those changes, commit and it should pass. |
|
@ashiramin, can you continue working on this? Let us know if anything is blocking you. |
@krysal I'm sorry I had some local dev issues unrelated to this project. I got it all fixed up so I'll work on it next week. Thanks for reaching out |
3b91f4c to
3dcadc9
Compare
3dcadc9 to
ad1537e
Compare
dhruvkb
left a comment
There was a problem hiding this comment.
The changes look good to me! Thanks for your contribution @ashiramin.
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
5ff056c to
d733964
Compare
|
@dhruvkb is this good to be merged? |
dhruvkb
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution @ashiramin!
krysal
left a comment
There was a problem hiding this comment.
Great, I confirmed the function continues to work for one of the affected DAGs.
Thank you, @ashiramin!

Fixes
Fixes #4884
Description
notify_slackmethod now determines dag_id through context variablesTesting Instructions
Checklist
Update index.md).main) or a parent feature branch.ov just catalog/generate-docsfor catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-propsfor the catalog or
ov just api/generate-docsfor the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin