Revert global snackbar z-index bump, implement alternative fix for Media Upload Modal notices#76067
Merged
andrewserong merged 3 commits intotrunkfrom Mar 3, 2026
Merged
Conversation
andrewserong
requested review from
aaronrobertshaw,
ramonjd,
talldan and
tellthemachines
andrewserong
added
[Type] Bug
|
Size Change: +560 B (+0.01%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Mar 3, 2026
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Nicely contained.
I checked that snackbars retain z-index: 100000; media upload snackbars get:
.media-upload-modal__snackbar {
z-index: 200000;
}
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Thanks for the quick review! 🙇 |
Contributor
|
Thanks for the follow-up! For now, I think this is the safe approach. |
gziolo
pushed a commit
that referenced
this pull request
Mar 3, 2026
…dia Upload Modal notices (#76067) * Revert "Media Notices: Bump global snackbar z-index, re-use global notices for media modal (#76063)" This reverts commit e59c2cb. * Modal Modal Notices: Try an alternative to fix fly in of notices * Remove explicit dismiss Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
alecgeatches
pushed a commit
to Automattic/gutenberg
that referenced
this pull request
Mar 3, 2026
…dia Upload Modal notices (WordPress#76067) * Revert "Media Notices: Bump global snackbar z-index, re-use global notices for media modal (WordPress#76063)" This reverts commit e59c2cb. * Modal Modal Notices: Try an alternative to fix fly in of notices * Remove explicit dismiss Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Contributor
Author
|
Thanks @t-hamano, again as always, I appreciate your feedback and guidance on these things! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Reverts #76063 while adding an alternative fix.
This restores the
z-indexfor snackbars in general to what it was, and instead applies the higher z-index to a version of the Snackbars particular to the media modal, rendered to the document via a portal.It then overrides the transforms that are causing an issue in this context.
Why?
As flagged in a post-merge comment in #76063, changing the z-index globally of snackbars has broader accessibility (and design) concerns. The approach in this PR is a bit more conservative and only affects notices generated by the media modal.
The move to using a portal and overriding transforms is a way to mitigate the conflict caused by the Image block's Replace flow popover with the Framer Motion transforms applied to the snackbars.
By using an isolated version of Snackbars that are just used by the media modal, we contain our logic, overrides, and hacks, and (hopefully) cause less impact on other areas of the editor.
How?
Testing Instructions
Enable the media modal experiment in Gutenberg settings:
Testing Instructions for Keyboard
Screenshots or screencast
See screenshots in #76063. It should still look like this:
2026-03-03.12.40.38.mp4