Fix resetting menu checked state from a separate menu#76041
Open
Fix resetting menu checked state from a separate menu#76041
Conversation
|
Size Change: +9 B (0%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Mar 4, 2026
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
This tests well 👍
I also verified that the Menu story with radios works well (/?path=/story/components-menu--with-radios).
Lastly, can this use a unit test before merging?
mirka
reviewed
Mar 4, 2026
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Confirmed that this doesn't happen with checkbox items 👍
Reported upstream at ariakit/ariakit#5483
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In DataViews, the checked status of a menu option might be reset from a separate menu. Ie, sorting by Column A should reset the 'checked' status of sorting menu items from Column B. Currently, that doesn't work because whether an option is checked or not only depends on that specific menu store.
This PR fixes it by allowing
props.checkedto take priority over the menu store to decide whether a menu item should be marked as checked or not.Testing Instructions
Note: in the screenshot above, notice that the table is currently sorted by Title, so the sorting options in the Categories columns should both look as not checked.