Fix: Suppress spinner output when using --json flag in wp-env#75743
Merged
youknowriad merged 1 commit intotrunkfrom Feb 24, 2026
Merged
Fix: Suppress spinner output when using --json flag in wp-env#75743youknowriad merged 1 commit intotrunkfrom
youknowriad merged 1 commit intotrunkfrom
Conversation
youknowriad
requested review from
ObliviousHarmony and
t-hamano
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 6.84 MB ℹ️ View Unchanged
|
youknowriad
force-pushed
the
reply-gh-comment-75020
branch
from
b25c191 to
08ab298
Compare
|
Flaky tests detected in 08ab298. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22216484801
|
The spinner animation and success message were leaking into JSON output from the status command and any future commands using the --json flag. This made the output unparseable by tools like jq. Updated the withSpinner wrapper to conditionally start/stop the spinner and skip the success message when --json is set, ensuring clean JSON output. Fixes #75020 (comment) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
youknowriad
force-pushed
the
reply-gh-comment-75020
branch
from
08ab298 to
3851115
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #75020 to fix JSON output pollution.
Why?
The
status --jsoncommand and any future commands with--jsonsupport were outputting spinner animation and success messages to stdout, making the JSON output unparseable by tools likejq.How?
Modified the
withSpinnerwrapper incli.jsto:--jsonis not set--jsonis setThis ensures clean, parseable JSON output when the flag is used.
Testing Instructions
npx wp-env status --json | jq .— should parse cleanly without errorsnpx wp-env status(without flag) — should still show spinner and timing message as beforenpx wp-env status --json --debug— should output clean JSON (no debug logs mixed in)