Skip to content

Icon Block: Corrects style selectors when global styles are set.#75724

Merged
t-hamano merged 2 commits intotrunkfrom
fix/icon-block-global-styles
Feb 20, 2026
Merged

Icon Block: Corrects style selectors when global styles are set.#75724
t-hamano merged 2 commits intotrunkfrom
fix/icon-block-global-styles

Conversation

@shimotmk
Copy link
Contributor

What?

Icon Block: Corrects style selectors when global styles are set.

Why?

The icon block renders styles to svg using __experimentalSkipSerialization, so the global style selectors will also match.

How?

Testing Instructions

  1. Changes the global style for site editor icons.
  2. You'll see that the default styles are now rendered correctly.

Testing Instructions for Keyboard

Screenshots or screencast

Before After
before after
@shimotmk shimotmk self-assigned this Feb 19, 2026
@shimotmk shimotmk added the [Block] Icon Affects the Icon block label Feb 19, 2026
@github-actions github-actions bot added the [Package] Block library /packages/block-library label Feb 19, 2026
@github-actions
Copy link

github-actions bot commented Feb 19, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shimotmk shimotmk requested a review from t-hamano February 19, 2026 12:32
@shimotmk shimotmk added the [Type] Bug An existing feature does not function as intended label Feb 19, 2026
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! If possible, let's ship this fix into 7.0 Beta1.

@t-hamano t-hamano added Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) Backport to WP 7.0 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Feb 19, 2026
@github-actions
Copy link

Flaky tests detected in 3b59d3e.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22217912512
📝 Reported issues:

@t-hamano t-hamano merged commit 83f5d4d into trunk Feb 20, 2026
47 of 48 checks passed
@t-hamano t-hamano deleted the fix/icon-block-global-styles branch February 20, 2026 10:18
@github-actions github-actions bot added this to the Gutenberg 22.7 milestone Feb 20, 2026
@github-actions github-actions bot removed the Backport to WP 7.0 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 20, 2026
gutenbergplugin pushed a commit that referenced this pull request Feb 20, 2026
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
@github-actions github-actions bot added the Backported to WP Core Pull request that has been successfully merged into WP Core label Feb 20, 2026
@github-actions
Copy link

I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 2ab1212

pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Feb 20, 2026
CI run: #10988.

See #64595.

---

I've included a log of the Gutenberg changes with the following command:

```
git log --reverse --format="- %s" b441348bb7e05af351c250b74283f253acaf9138..23b566c72e9c4a36219ef5d6e62890f05551f6cb | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy
```

- Remove experimental property from Icon block (WordPress/gutenberg#75742)
- Real-time collab editing: Fix undo E2E test (WordPress/gutenberg#75740)
- Snackbar: Fix scaling issue with snackbars that update their content via a common id (WordPress/gutenberg#75709)
- Vips and worker-threads packages: remove private flag so that packages can be published to npm (WordPress/gutenberg#75752)
- Update wordpress/vips in root package.json to use a relative path (WordPress/gutenberg#75758)
- Fix change-detection and new-post E2E tests after RTC enabled by default (WordPress/gutenberg#75751)
- Query: Remove content role from block (WordPress/gutenberg#75760)
- `ToggleGroupControl`: Make unselected item color consistent across all variants (WordPress/gutenberg#75737)
- Icon-block: fix global-styles selectors (WordPress/gutenberg#75724)
- RTC: Add cap check for single taxonomy term entities (WordPress/gutenberg#75708)
- Core Data: Create icons entity (WordPress/gutenberg#75773)


git-svn-id: https://develop.svn.wordpress.org/trunk@61705 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Feb 20, 2026
CI run: WordPress/wordpress-develop#10988.

See #64595.

---

I've included a log of the Gutenberg changes with the following command:

```
git log --reverse --format="- %s" b441348bb7e05af351c250b74283f253acaf9138..23b566c72e9c4a36219ef5d6e62890f05551f6cb | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy
```

- Remove experimental property from Icon block (WordPress/gutenberg#75742)
- Real-time collab editing: Fix undo E2E test (WordPress/gutenberg#75740)
- Snackbar: Fix scaling issue with snackbars that update their content via a common id (WordPress/gutenberg#75709)
- Vips and worker-threads packages: remove private flag so that packages can be published to npm (WordPress/gutenberg#75752)
- Update wordpress/vips in root package.json to use a relative path (WordPress/gutenberg#75758)
- Fix change-detection and new-post E2E tests after RTC enabled by default (WordPress/gutenberg#75751)
- Query: Remove content role from block (WordPress/gutenberg#75760)
- `ToggleGroupControl`: Make unselected item color consistent across all variants (WordPress/gutenberg#75737)
- Icon-block: fix global-styles selectors (WordPress/gutenberg#75724)
- RTC: Add cap check for single taxonomy term entities (WordPress/gutenberg#75708)
- Core Data: Create icons entity (WordPress/gutenberg#75773)

Built from https://develop.svn.wordpress.org/trunk@61705


git-svn-id: http://core.svn.wordpress.org/trunk@61013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@ockham ockham modified the milestones: Gutenberg 22.7, Gutenberg 22.6 Feb 23, 2026
ockham pushed a commit that referenced this pull request Feb 23, 2026
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
@ockham
Copy link
Contributor

ockham commented Feb 23, 2026

I just cherry-picked this PR to the release/22.6 branch to get it included in the next release: 3686a69

@ockham ockham removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Feb 23, 2026
scruffian pushed a commit that referenced this pull request Feb 23, 2026
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backported to WP Core Pull request that has been successfully merged into WP Core [Block] Icon Affects the Icon block [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended

3 participants