Project Management: Add components team as codeowners for components package#75641
Project Management: Add components team as codeowners for components package#75641
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Let's try this out |
Co-authored-by: aduth <aduth@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>
Co-authored-by: aduth <aduth@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>
Co-authored-by: aduth <aduth@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>
What?
Updates the GitHub CODEOWNERS file to add @WordPress/gutenberg-components as codeowners of the
@wordpress/componentspackage.Why?
The purpose of this team is to provide feedback to common UI components used and maintained in Gutenberg, and it should follow that the team should be looped into any proposed changes to those components. This is the same justification as used for adding code ownership for
@wordpress/uiand@wordpress/themein #73369, and the team's scope includes@wordpress/componentsas well.The main counter-point to this argument would be that it increases the potential notification burden for an already-small team, which is largely the reason it hadn't been done until now. I'm sensitive to this point as well, so happy to opt against this change if there's concern and would invite feedback from the team.
Testing Instructions
Verify that the syntax and team name is correct in the CODEOWNERS file based on the specification and related entries. The GitHub UI should also show the code owners file as valid (screenshot).