Real-time Collaboration: Bug fix for CRDT user selection and add tests#75075
Real-time Collaboration: Bug fix for CRDT user selection and add tests#75075ingeniumed merged 4 commits intotrunkfrom
Conversation
…ey not existing in a block but in a selection
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
…for-crdt-user-selection
|
Flaky tests detected in 907bece. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21851645978
|
…for-crdt-user-selection
#75075) * Add test for crdt-user-selection and fix a bug related to attribute key not existing in a block but in a selection * CR based on feedback
|
I just cherry-picked this PR to the release/22.6 branch to get it included in the next release: b94dd25 |
#75075) * Add test for crdt-user-selection and fix a bug related to attribute key not existing in a block but in a selection * CR based on feedback
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 6a29af0 |
What?
Fix a bug in the CRDT user selection when an attribute is not found on a block, even though it exists in the selection. Also, add tests for this class within the core-data package.
Why?
Tests are important, so this is critical. I did this in a separate PR to minimize the changes that were made.
Testing Instructions
Run the tests
Testing Instructions for Keyboard
None