Revert "Set image width to fit-content to solve aspect ratio problems in Firefox. (#66217)"#66804
Merged
kevin940726 merged 1 commit intotrunkfrom Nov 7, 2024
Merged
Conversation
kevin940726
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -110 B (-0.01%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
mukeshpanchal27
approved these changes
Nov 7, 2024
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks for handling. LGTM
2 tasks
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: e503a39 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…ms in Firefox. (WordPress#66217)" (WordPress#66804) Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org> Co-authored-by: juanfra <juanfra@git.wordpress.org> This reverts commit 0e65adc.
priethor
added
the
Backport to Gutenberg Minor Release
Contributor
|
Backported to Gutenberg 19.6.3 in 51e9978 |
priethor
removed
the
Backport to Gutenberg Minor Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0e65adc.
What and Why?
This is an alternative to #66801.
As reported both in #66643 and #66801. The
fit-contentrule possibly introduced too many side effects that it's safer to revert it for now.This probably means we have to find another way to resolve the issue with TT5 patterns. (Reopen #66175)
How?
Revert the commit in both #66217 and #66643.
Testing Instructions
Follow the instructions in #66801. See https://core.trac.wordpress.org/ticket/62345 too.
Screenshots or screencast
N/A