Fix: use active variation as the parent block if available#44609
Merged
ntsekouras merged 1 commit intoWordPress:trunkfrom Oct 7, 2022
Merged
Conversation
carolinan
approved these changes
Oct 3, 2022
Contributor
carolinan
left a comment
There was a problem hiding this comment.
I tested this by adding a row group block variation with a paragraph inside.
Before: The menu would show "Select parent block (group)"
With PR: The menu shows "Select parent block (row)"
The pr works well in my test.
Member
Author
Using Row is much easier for testing. I updated the reproduce steps using yours, thank you so much! |
7 tasks
ntsekouras
approved these changes
Oct 7, 2022
Contributor
ntsekouras
left a comment
There was a problem hiding this comment.
Looks good, thanks @dinhtungdu !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR shows the active variation info in the inner block's menu if the parent block is a variation.
Why?
Fixes #44608
If the current parent block is a variation, it's better to display the variation title and icon in the block menu. Otherwise, it can make users confused.
How?
This PR checks if the first parent block is a variation and then uses the active variation as the parent block, so the correct metadata is displayed in the block menu:
Select parent block (...)item.Testing Instructions
Select parent block (Row).Or check out this PR, add a filter block to the page and check the block menu of inner block as screenshots show: woocommerce/woocommerce-blocks#6978
Screenshots or screencast
Before this PR
With this PR