Migrate mentions tests to playwright#43064
Conversation
|
FYI: First two test cases are passing, but the last one "Insert two subsequent mentions" is not passing. |
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Thanks for working on this.
packages/e2e-test-utils-playwright/src/editor/click-block-appender.ts
Outdated
Show resolved
Hide resolved
|
Hey @talldan |
|
@kevin940726 @JustinyAhin Can you please check if it looks good to you ? |
kevin940726
left a comment
kevin940726
left a comment
There was a problem hiding this comment.
Sorry for the late reviews! Thanks for your patience!
package-lock.json
Outdated
| "version": "1.0.2", | ||
| "resolved": "https://registry.npmjs.org/app-root-dir/-/app-root-dir-1.0.2.tgz", | ||
| "integrity": "sha512-jlpIfsOoNoafl92Sz//64uQHGSyMrD2vYG5d8o2a4qGvyNCvXur7bzIsWtAC/6flI2RYAp3kv8rsfBtaLm7w0g==", | ||
| "integrity": "sha1-OBh+wt6nV3//Az/8sSFyaS/24Rg=", |
There was a problem hiding this comment.
Not sure why this file is changed?
There was a problem hiding this comment.
I haven't made any changes to these files 🤔
There was a problem hiding this comment.
Yeah, it could be like that sometimes after running npm install. You can just revert the changes here by running git checkout trunk -- package-lock.json or something similar.
packages/e2e-test-utils-playwright/src/editor/click-block-appender.ts
Outdated
Show resolved
Hide resolved
|
Hey @kevin940726 |
|
Hi there! I don't think all the feedback has been addressed yet 😅 . Would you mind checking it again? |
|
@kevin940726 Yeah you are right :D it got missed somehow. Addressed now, the only one thing I am not really sure, what do I need to do to fix that, left comment there. |
kevin940726
left a comment
kevin940726
left a comment
There was a problem hiding this comment.
Looks good to me! Just some accidentally changed files left 💯
|
@kevin940726 It should be fine now, I hope. |
|
There are still changes in the |
juhi123
force-pushed
the
add/playwright-mention-test
branch
3 times, most recently
from
dedeb79 to
712a223
Compare
Somehow code editor was applying formatting everytime after commit
|
@kevin940726 Thanks for your patience. Now I can see only 2 files changed, so it should be good now 🤞 |
3 participants
What?
Part of #38851. Migrate mentions.test.js to its Playwright version.
Why?
See this post for an overview of the migration.
How?
By following the migration guide.
Testing Instructions
Run
npm run test-e2e:playwright test/e2e/specs/editor/various/mentions.spec.js