Docs: add step for build and asset file#41511
Conversation
There was a missing step in the plain javascript documentation which missed out adding the asset file. Issue WordPress#40447
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @tharsheblows! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
ryanwelcher
left a comment
There was a problem hiding this comment.
LGTM! Thanks for putting this together!
|
Congratulations on your first merged pull request, @tharsheblows! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
|
I'm not sure if this is the correct spot for this comment, but I landed here via Google, so here it goes... The block.json docs are still confusing, IMO. I'm not sure I would've figured out why my block wasn't loading its JS file if I hadn't thought to check the
The type definitions for both style and script are the same in the docs, It makes sense; scripts loaded without their dependencies will break things. Yet despite showing It was hard to find useful info via Google, so if I hadn't had debugging enabled to alert me to the problem, I likely would've soon set up my own block scripts loader in |
There was a missing step in the plain javascript documentation which missed out adding the asset file. Issue #40447
Done during WCEU 2022 Contributor day! 🎉