Remove pointless <span>s in Custom HTML block controls.#39820
Merged
amustaque97 merged 1 commit intotrunkfrom Apr 11, 2022
Merged
Remove pointless <span>s in Custom HTML block controls.#39820amustaque97 merged 1 commit intotrunkfrom
<span>s in Custom HTML block controls.#39820amustaque97 merged 1 commit intotrunkfrom
Conversation
ZebulanStanphill
added
[Type] Code Quality
|
Size Change: -11 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Mar 29, 2022
ZebulanStanphill
force-pushed
the
update/simplify-html-block-ui-markup
branch
from
2a35de4 to
f59e3f2
Compare
ZebulanStanphill
added
the
Good First Review
amustaque97
approved these changes
Apr 11, 2022
Member
amustaque97
left a comment
amustaque97
left a comment
There was a problem hiding this comment.
Thank you @ZebulanStanphill for working on this. Changes LGTM 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR simplifies the markup of the HTML block controls by removing some pointless wrapping elements.
Why?
Because the useless markup annoyed me.
How?
It removes some pointless
<span>wrappers in the HTML block's<ToolbarButton>s.Testing Instructions
Screenshots
Before
After