Abilities Explorer: Remove cb column.#246
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #246 +/- ##
=============================================
- Coverage 55.84% 55.75% -0.09%
+ Complexity 508 507 -1
=============================================
Files 32 32
Lines 2611 2606 -5
=============================================
- Hits 1458 1453 -5
Misses 1153 1153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Yeah, I suppose that was there with the assumption there was some sort of bulk actions which are not present so fine by me to remove as long as @dkotter is happy with the technical changes here to proceed on approve/merge |
| '<input type="checkbox" name="abilities[]" value="%s" />', | ||
| esc_attr( $item['slug'] ) | ||
| ); | ||
| _deprecated_function( __FUNCTION__, 'x.x.x', 'The checkbox column is no longer displayed.' ); |
There was a problem hiding this comment.
Do we need to deprecate this? I understand that's the typical best approach but in this case:
- Seems unlikely anyone is overriding this
- But if they are, this method exists on the
WP_List_Tableclass we're extending so if we remove this method entirely (instead of deprecating) anyone extending this won't run into problems (I don't think)
There was a problem hiding this comment.
Thanks for the review!
- Seems unlikely anyone is overriding this
- But if they are, this method exists on the WP_List_Table class we're extending so if we remove this method entirely (instead of deprecating) anyone extending this won't run into problems (I don't think).
Fair point, I went this route because it's a public method, and even though the chance of someone overriding it is pretty minimal, seemed appropriate to be a bit defensive.
Totally fine with removing it completely though :)
What?
Removes the unused "cb" (checkbox) column from the Abilities Explorer table and deprecates the related method.
Why?
The "cb" column is intended for bulk actions, which we don't have in the Abilities Explorer. Having it there is confusing and clutters the UI.
How?
Removed the "cb" column from the table display and deprecated the public method that handled it (to avoid breaking changes if extended elsewhere).
Testing Instructions
Screenshots or screencast