Conversation
background color change
| } | ||
| } | ||
| .wp-block-sensei-lms-course-results.is-style-default .wp-block-sensei-lms-course-results__module-header:not(.has-background) { | ||
| background-color: #eee |
There was a problem hiding this comment.
Isn't this line ended with a semi-colon (;) in the last? For the consistent code practice according to the file.
There was a problem hiding this comment.
thanks - I've updated this
missing semicolon
|
@adamwoodnz when you have a moment, could you review this, and if you're happy with it, merge it in. Thanks |
jonathanbossenger
added
[Dev] Needs Review
adamwoodnz
left a comment
adamwoodnz
left a comment
There was a problem hiding this comment.
Code changes look ok to me, other than the whitespace comment.
I can't reproduce this though, completion screens look like this for me:
Has the UI changed with a later Sensei version, or does it need to be a specific course?
Co-authored-by: Adam Wood <1017872+adamwoodnz@users.noreply.github.com>
|
@adamwoodnz the module section divider is what we would like a different background colour for. Here's a screenshot of what's currently on the production site. Does this help?
|
adamwoodnz
left a comment
adamwoodnz
left a comment
There was a problem hiding this comment.
I can't reproduce this, but it's such a minor change I'm happy to ship it and @bsanevans and @cynthianorman can verify the fix.
5 participants
background color change
PR for #1874