Repository navigation
Allow derivePassword counter to accept any integer type - #486
Open
bejaratommy wants to merge 1 commit into
Open
bejaratommy wants to merge 1 commit into
bejaratommy wants to merge 1 commit into
Conversation
Previously derivePassword required its counter argument to be a
uint32, which meant it could not be called with the int index
produced by a range loop (e.g. in Helm templates) without an
explicit, awkward conversion. The counter is now accepted as
interface{} and coerced with cast.ToUint32, matching the pattern
already used by toInt/toInt64 in numeric.go.
Fixes Masterminds#108
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
derivePassword'scounterargument was typed asuint32. Go'stext/templatedoes reflection-based argument matching, so callingderivePasswordwith anint— such as the loop index produced by Helm'srange $i, $v := ...— fails at template execution time with a type mismatch error. There was no ergonomic way to derive multiple passwords in a loop.This changes
counterto acceptinterface{}and coerces it internally withcast.ToUint32, mirroring the existingtoInt/toInt64pattern innumeric.go(thegithub.com/spf13/castdependency is already used elsewhere in this repo).Fixes #108
Changes
crypto.go:derivePasswordcounter param changed fromuint32tointerface{}, coerced viacast.ToUint32.crypto_test.go: addedTestDerivePasswordCounterTypes, a regression test covering a literal int, a template variable, and arange-produced index, all asserted to produce the same output as the existing literal-uint case.docs/crypto.md: documented that the counter argument accepts any integer type.Testing
go build ./...go test ./... -run TestDerivePassword -v— passesgo test ./...— one pre-existing, unrelated failure (TestRoundinnumeric_test.go, a floating-point rounding assertion) reproduces identically onmasterbefore this change; not touched by this PR.