[ricardbejarano]

Summary

regexFindAll, regexReplaceAll, regexReplaceAllLiteral and regexSplit take the subject string as a middle argument instead of last. Go template pipelines always pass the previous pipeline value as the last argument to the next function, so these functions are effectively unusable in a pipeline — you have to stash the subject in a variable first instead of writing $s | regexReplaceAll "a(x*)b" "${1}W".

This is Masterminds/sprig#86, acknowledged by maintainer @mattfarina:

So, the path forward would be to have some new regex functions, with new names, that have a different ordering. This would be a feature request. PRs are welcome.

Per the discussion, a breaking change to the existing functions' argument order isn't acceptable (existing templates depend on it), so this PR adds new, additive *Global variants instead, leaving the existing functions untouched:

• regexFindAllGlobal / mustRegexFindAllGlobal
• regexReplaceAllGlobal / mustRegexReplaceAllGlobal
• regexReplaceAllLiteralGlobal / mustRegexReplaceAllLiteralGlobal
• regexSplitGlobal / mustRegexSplitGlobal

Each mirrors its existing counterpart but with the subject string moved to the last argument, e.g.:

{{ $s | regexReplaceAllGlobal "a(x*)b" "${1}W" }}

regexMatch/mustRegexMatch and regexFind/mustRegexFind already take the subject string as the last argument, so they don't need a *Global counterpart.

Changes

• regex.go: new *Global functions, implemented by delegating to the existing functions with reordered arguments.
• functions.go: register the new functions in the template function map.
• regex_test.go: unit tests for each new function (mirroring the existing test cases) plus a text/template pipeline test proving $s | regexXxxGlobal ... actually works.
• docs/strings.md: document each new function next to its existing counterpart.

Testing

• go build ./...
• go vet ./...
• go test ./... — passes except for the pre-existing, unrelated TestRound floating-point flake on numeric.go, which also fails on unmodified master.

Fixes #86