Repository navigation
Use :contiguous in N-index pyarray_offset - #836
Merged
Merged
Conversation
The Vararg method ignored the flag, and it is also the one picked for 1-D linear indexing, so sum over a contiguous vector didn't vectorise.
Member
|
Thanks! I simplified it a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Varargmethod ofpyarray_offsetignored:contiguous. ForN == 1it's also the one picked overpyarray_offset(x, i::Int), sosumover a contiguous vector still multiplied by the runtime stride and didn't vectorise.sumof a 1e7 Float32 vector, Julia 1.13.1, Apple M1: 4.44 ms before, 0.45 ms after, 0.44 ms forArray.This also speeds up Cartesian indexing of contiguous N-d arrays. #835 does the same for 0.9 without the flag.