Repository navigation
Conversation
Towards internal issue b/579906804
|
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces new BigQuery samples for BigFrames, pandas-gbq migration, and Polars, including corresponding tests and configuration files. The review feedback highlights several necessary corrections: fixing a SQL syntax error (trailing comma) and mismatched region tags in the Polars samples, adhering to PEP 8 by removing spaces around keyword argument assignment, correcting a return type annotation in the BigFrames dry run sample, simplifying dependency requirements by removing markers for unsupported Python versions (< 3.10), and updating the test configuration to include Python 3.13.
|
|
||
| def query_dry_run( | ||
| project_id: str = "your-project-id", | ||
| ) -> Tuple[pd.Series, pd.Series]: |
There was a problem hiding this comment.
There was a problem hiding this comment.
BigFrames does return a panda Series.
| pandas==2.0.3; python_version == '3.8' | ||
| pandas==2.2.3; python_version > '3.8' | ||
| pandas-gbq==0.24.0 | ||
| pandas==2.2.3; python_version < '3.11' | ||
| pandas==3.1.0; python_version >= '3.11' | ||
| pandas-gbq==0.35.3 | ||
| grpcio==1.70.0; python_version == '3.8' | ||
| grpcio==1.74.0; python_version > '3.8' | ||
| grpcio==1.74.0; python_version == '3.9' | ||
| grpcio==1.85.1; python_version >= '3.10' |
There was a problem hiding this comment.
Python versions below 3.10 are no longer supported. Please remove the fallback dependency versions and environment markers for Python 3.8 and 3.9, and simplify the requirements accordingly.
pandas==2.2.3; python_version < '3.11'
pandas==3.1.0; python_version >= '3.11'
pandas-gbq==0.35.3
grpcio==1.85.1
References
- Do not specify fallback dependency versions or environment markers for Python versions older than 3.10, as Python versions below 3.10 are no longer supported.
| TEST_CONFIG_OVERRIDE = { | ||
| # You can opt out from the test for specific Python versions. | ||
| # Skipping for Python 3.9 due to pyarrow compilation failure. | ||
| "ignored_versions": ["3.8", "3.9", "3.11", "3.12", "3.13"], |
There was a problem hiding this comment.
To adhere to the testing policy of only testing the oldest and newest supported Python releases, we should test Python 3.10 (oldest) and Python 3.13 (newest). Please remove Python 3.13 from the ignored versions list so that it is included in the test suite.
| "ignored_versions": ["3.8", "3.9", "3.11", "3.12", "3.13"], | |
| "ignored_versions": ["3.8", "3.9", "3.11", "3.12"], |
References
- Only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Towards internal issue b/579906804
Description
Fixes #
Checklist
Testing
Compliance & Style
Post-Approval Actions