loader worker-plugin/loader is not found by webpack #62

Activity

1. developit commented on Mar 16, 2020

   

   developit

   on Mar 16, 2020

   Contributor

   More actions

   @stephanemagnenat TypeScript doesn't allow loader syntax in imports - I'd recommend using Webpack configuration to apply the loader instead:

   module.exports = {
     module: {
       rules: [
         {
           test: /\.worklet\.(js|ts)x?$/,
           loader: 'worker-plugin/loader'
         }
       ]
     }
   }

   With the above in your Webpack configuration, you should be able to do:

   import musicWorkletURL from './music.worklet';

   I'm not aware of any clean way to specify types for this, so I'd recommend casting the value to a String.
2. developit

   added

   questionFurther information is requestedFurther information is requested

   on Mar 16, 2020
3. stephanemagnenat commented on Mar 16, 2020

   

   stephanemagnenat

   on Mar 16, 2020

   Last edited by stephanemagnenat

   Author

   More actions

   Thank you for your answer! I am using Webpack actually. I also tried the option you propose before posting the issue, but then Webpack crashed at startup due to the node VM exhausting its memory. It seems that in my configuration, something triggers an infinite loop in Webpack when using a rule with the worker-plugin (but not with other plugins), and a non-detection when using the loader syntax in imports. So I see no other way to find the source of the issue than to make a minimal test case, and if the latter works, to bisect between it and my configuration until the problem appears. Of course it would take some time, that is why I did not do it yet.
4. developit commented on Mar 23, 2020

   

   developit

   on Mar 23, 2020

   Last edited by developit

   Contributor

   More actions

   @stephanemagnenat Sounds tricky. A reproduction would be super helpful as you mentioned.

   In the meantime, I think one way to work around this would be to configure the loader so that it only runs in your main compiler, not any compilers spawned by worker-plugin or things like html-webpack-plugin. That would look something like this:

   module.exports = {
     name: 'main',  // if you don't have this already. must match the Rule below
     module: {
       rules: [
         (info) => ({
           test: /\.worklet\.(js|ts)x?$/,
           // only apply to main compilation:
           include: () => info.compiler === 'main',
           loader: 'worker-plugin/loader'
         })
       ]
     }
   }
5. developit commented on May 3, 2020

   

   developit

   on May 3, 2020

   Contributor

   More actions

   @stephanemagnenat any chance this issue went away? I noticed that the original issue was filed on May 11th, which is only one day after I released a hotfix that added loader.js to the npm bundle (it was missing in 4.0.0 and 4.0.1). Would be good to check npm ls worker-plugin for the installed version (regardless of the package.json value).
6. developit

   added

   needs more info

   on May 3, 2020
7. stephanemagnenat commented on May 3, 2020

   

   stephanemagnenat

   on May 3, 2020

   Author

   More actions

   I am positive I used the very-up-to-date version by then loader.js was in the npm bundle. I did not find time to create a minimal reproducible test case, because as I said the issue is not trivial but also because in between I changed my design not to use a worklet. I can try to have another look tomorrow.
8. hunyoboy commented on May 6, 2020

   

   hunyoboy

   on May 6, 2020

   More actions

   I'm still experiencing this crash issue. Using the webpack configuration and doing the direct import of worker file. I'm using latest 4.0.3.

   👍React with 👍2Reacted by Jason Miller and dilshod
9. developit commented on May 6, 2020

   

   developit

   on May 6, 2020

   Contributor

   More actions

   I think I know what is causing the crash, will try to reproduce so I can add a fix.

   👍React with 👍3Reacted by Joel Capillo, Stefan Charsley and dilshod
10. charsleysa commented on Jul 19, 2020

    

    charsleysa

    on Jul 19, 2020

    More actions

    @developit has there been any progress on this?
11. developit commented on Aug 11, 2020

    

    developit

    on Aug 11, 2020

    Contributor

    More actions

    I haven't been able to reproduce the issue. If anyone has a reproduction I can look at, that would be helpful.