fix: Handle the case when theme_color is not set#909
Merged
westonruter merged 1 commit intoGoogleChromeLabs:developfrom Feb 22, 2023
Merged
fix: Handle the case when theme_color is not set#909westonruter merged 1 commit intoGoogleChromeLabs:developfrom
theme_color is not set#909westonruter merged 1 commit intoGoogleChromeLabs:developfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
@westonruter Could you please review and merge my pull request? |
Collaborator
|
@rafaucau I need you to sign the Contributor License Agreement before it can be merged. |
Contributor
Author
|
@westonruter I signed it as soon as this PR was sent: |
Collaborator
|
Sorry, my mistake. |
westonruter
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #901
If
theme_coloris unset, the empty tag<meta name="theme-color" content>will no longer be added in the<head>.