Skip to content

Update error messages html comment placeholders with mustache tags#720

Merged
westonruter merged 1 commit intodevelopfrom
update/error-messages-placeholder
Mar 2, 2022
Merged

Update error messages html comment placeholders with mustache tags#720
westonruter merged 1 commit intodevelopfrom
update/error-messages-placeholder

Conversation

@thelovekesh
Copy link
Collaborator

Fixes #709

HTML comment placeholders get stripped by HTML minifiers. So update those HTML comment placeholders with Moustache tags.

* HTML comment placeholders get stripped by HTML minifiers.
@thelovekesh thelovekesh requested a review from westonruter March 2, 2022 15:34
@codecov-commenter
Copy link

Codecov Report

Merging #720 (da9321a) into develop (ad09837) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #720   +/-   ##
==========================================
  Coverage      19.96%   19.96%           
  Complexity       326      326           
==========================================
  Files             56       56           
  Lines           2094     2094           
==========================================
  Hits             418      418           
  Misses          1676     1676           
Flag Coverage Δ
php 19.96% <0.00%> (ø)
unit 19.96% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wp-admin/error.php 0.00% <0.00%> (ø)
wp-includes/template.php 11.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad09837...da9321a. Read the comment docs.

@westonruter westonruter added this to the 0.7 milestone Mar 2, 2022
@westonruter westonruter merged commit 3cc9952 into develop Mar 2, 2022
@westonruter westonruter deleted the update/error-messages-placeholder branch March 2, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment