Use plugins_url() to allow Workbox script URLs to be filtered#600
Merged
westonruter merged 2 commits intodevelopfrom Aug 24, 2021
Merged
Use plugins_url() to allow Workbox script URLs to be filtered#600westonruter merged 2 commits intodevelopfrom
plugins_url() to allow Workbox script URLs to be filtered#600westonruter merged 2 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## update/skip-waiting-message #600 +/- ##
=================================================================
- Coverage 16.78% 16.74% -0.05%
Complexity 305 305
=================================================================
Files 55 55
Lines 2008 2013 +5
=================================================================
Hits 337 337
- Misses 1671 1676 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
df1598b to
8f87703
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #543.
Let's say you have all of the PWA plugin's files located at a CDN with the URL
https://pwa-wp-cdn.example.com/. You could achieve that with the following plugin code: