Skip to content

Ensure $current_screen global is set before applying admin_title filter#207

Merged
westonruter merged 2 commits intomasterfrom
fix/admin_title_filter_error
Aug 2, 2019
Merged

Ensure $current_screen global is set before applying admin_title filter#207
westonruter merged 2 commits intomasterfrom
fix/admin_title_filter_error

Conversation

@westonruter
Copy link
Collaborator

Fixes #206.

@nuvoPoint
Copy link

We have implemented this fix and are keeping an eye on the log files for the next couple of hours to see if this fixes #206

@nuvoPoint
Copy link

We haven't see the fatal error yet in our logs, but now we are getting the following:

PHP Notice: Undefined index: hook_suffix in /var/www/html/wp-admin/includes/class-wp-screen.php on line 213

The only two things changed in our setup is this fix and #179

@westonruter
Copy link
Collaborator Author

@nuvoPoint Thanks for that. I've also set $hook_suffix to address this in ad7adab.

@nuvoPoint
Copy link

It seems to work fine now with $hook_suffix - thanks!

@westonruter westonruter merged commit d46b872 into master Aug 2, 2019
@westonruter westonruter deleted the fix/admin_title_filter_error branch August 2, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants