Prevent needless wordpress_sw_installed cookie from being set outside the wp-admin#189
Merged
westonruter merged 2 commits intomasterfrom Jul 4, 2019
Merged
Conversation
iandunn
approved these changes
Jul 4, 2019
iandunn
left a comment
iandunn
left a comment
There was a problem hiding this comment.
I tested the branch in a local WordCamp.org environment and it worked, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188.
The
wordpress_sw_installedcookie is only used to disable$concatenate_scriptsso it is only needed when installing the admin service worker. This PR limits the cookie to the admin and ensures the cookie path matches the admin scope: